[7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries (original) (raw)

Andrew Hughes ahughes at redhat.com
Thu Aug 23 14:45:34 UTC 2012

----- Original Message -----

I haven't seen any complaints from build-dev members so I would also assume that http://hg.openjdk.java.net/jdk8/build/jdk/ is a suitable repo.

I was thinking the same.

I'll update bug status once I see your push.

There you go:

http://hg.openjdk.java.net/jdk8/build/jdk/rev/baf30df50ce3

regards, Sean. > On 22/08/2012 10:29, David Holmes wrote: > On 22/08/2012 6:30 PM, Andrew Hughes wrote: >> ----- Original Message ----- >>> On 21/08/2012 9:37 PM, Seán Coffey wrote: >>>> Looks fine to me but best to get an official jdk8 reviewer. >>> >>> Looks fine to me too. >>> >> >> Thanks David. Is there a preferred tree for me to push this to? > > Not from me. > > David > ----- > >> >>>> I presume the filter-out option on macosx becomes a no-op (on >>>> OpenJDK >>>> builds) some lines later : (Images.gmk) >>>> >>>> 264 JDKMANPAGES := (filter−outjvisualvm.1,(filter-out jvisualvm.1, (filter−outjvisualvm.1,(JDKMANPAGES)) >>> >>> Yes. >>> >>>> On the subject of dual Makefile maintenance, are there plans to >>>> eventually remove >>>> the older/legacy makefile structure on 8? I haven't been >>>> monitoring >>>> that >>>> topic too closely. >>> >>> Yes. At some point "real soon now" we should make the switch to >>> using >>> the new build system for our official builds. Some of the work >>> for 8 >>> is >>> only being done in the context of the new build system. >>> >> >> I need to look at moving our builds to using the new system. >> >>> David >>> ---- >>> >>>> regards, >>>> Sean. >>>> >>>> On 21/08/2012 12:13, Andrew Hughes wrote: >>>>> Ah good catch. I didn't realise this was duplicated in the new >>>>> build >>>>> system. >>>>> >>>>> http://cr.openjdk.java.net/~andrew/jvisualvm/webrev.02/ >>>>> >>>>> should deal with both cases. >>>>> >>>>> If this is ok, is there a preferred forest to push to? I've >>>>> been >>>>> testing against >>>>> build, but can easily push it somewhere else. >>>> >>> >> >

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the build-dev mailing list