Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Tue Feb 7 16:30:47 UTC 2012
- Previous message (by thread): Fwd: hg: hsx/hotspot-rt/hotspot: 7141242: build-infra merge: Rename CPP->CXX and LINK->LD
- Next message (by thread): Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ <http://cr.openjdk.java.net/%7Eerikj/7141244/webrev.00/> 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg
7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
The build-infra project is starting to move into jdk8. For the hotspot build to stay compatible with the changes, key hotspot makefiles need to add an optional include statement:
-include $(SPEC)
In the new build system, the spec file is generated by configure and contains the configuration for the build. Only a handfull of files need to add this line.
In addition to including the spec file, some variables need to be changed to only be set conditionally so that a value from the spec file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, NAWK (and for windows RC and MT). The hotspot makefiles should check each variable if it's already set or if it has a gnumake default value.
These changes have been verified to work for hotspot-rt. Jdk7u will be verified as well before pushing.
/Erik
- Previous message (by thread): Fwd: hg: hsx/hotspot-rt/hotspot: 7141242: build-infra merge: Rename CPP->CXX and LINK->LD
- Next message (by thread): Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]