Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Wed Feb 8 08🔞11 UTC 2012

Thanks for taking a look.

While I haven't tried building in the way describe (yet), these changes shouldn't affect it. The idea is to leave everything in the hotspot build just like it is now, but let configure override things when configure is used, which is only when building the full forest.

/Erik

On 2012-02-08 02:54, Paul Hohensee wrote:

Thanks for the explanation. As long as I can still do builds from make/, I'm happy.

Paul On 2/7/12 7:42 PM, David Holmes wrote: On 8/02/2012 2:55 AM, Paul Hohensee wrote:

Can you make this work when building from the make/ directories? E.g., you could add the $(SPEC) include to make/solaris/Makefile, etc.

I'm not sure that makes sense. The SPEC file only exists for the new build and in the new build you run configure for each platform, so if you configured for solaris then that is the only build you can do there. You can't decide to do a linux build instead - you need to re-run configure. I'll take a look at this ASAP but am somewhat swamped right now. David

Thanks,

Paul On 2/7/12 11:30 AM, Erik Joelsson wrote: http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ <http://cr.openjdk.java.net/%7Eerikj/7141244/webrev.00/> 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg

7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable The build-infra project is starting to move into jdk8. For the hotspot build to stay compatible with the changes, key hotspot makefiles need to add an optional include statement:

-include $(SPEC) In the new build system, the spec file is generated by configure and contains the configuration for the build. Only a handfull of files need to add this line. In addition to including the spec file, some variables need to be changed to only be set conditionally so that a value from the spec file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, NAWK (and for windows RC and MT). The hotspot makefiles should check each variable if it's already set or if it has a gnumake default value. These changes have been verified to work for hotspot-rt. Jdk7u will be verified as well before pushing. /Erik

More information about the build-dev mailing list