Review Request : 7143162 : Allow disable building of jdk demos and samples (original) (raw)

Kelly O'Hair kelly.ohair at oracle.com
Tue Feb 28 01:53:57 UTC 2012


Looks fine to me.

-kto

On Feb 27, 2012, at 4:14 PM, Mike Duigou wrote:

Hello all;

WEBREV @ http://cr.openjdk.java.net/~mduigou/7143162/1/webrev/ An updated version of my previous webrev. I'm reposting it because this version includes a previously missing bit from the top level sanity makefile that produce warning notices when demos and samples are turned off similar to the NODOCS javadoc warning. Also includes a correction in Release.gmk. Overall this is fairly simple patch for review. It allows developers to shut off building of the jdk demos and samples. Disabling these builds has a very positive impact upon build turnaround for incremental builds. Export NODEMOS and/or NOSAMPLES in your shell before running make and demos and/or samples will be skipped. The default behaviour remains unchanged. Thanks, Mike



More information about the build-dev mailing list