Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS (original) (raw)
Tim Bell tim.bell at oracle.com
Mon Jul 2 15:56:10 UTC 2012
- Next message (by thread): Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 06/27/12 15:26, John Coomes wrote:
I only looked at the hotspot changes, which are fine. One minor request. In hotspot/make/windows/makefiles/defs.make: 215 else 216 ifeq ($(USINGMINGW), true) 217 ABSOUTPUTDIR := (shell(shell (shell(CD) (OUTPUTDIR);(OUTPUTDIR);(OUTPUTDIR);(PWD)) 218 ABSBOOTDIR := (shell(shell (shell(CD) (BOOTDIR);(BOOTDIR);(BOOTDIR);(PWD)) 219 ABSGAMMADIR := (shell(shell (shell(CD) (GAMMADIR);(GAMMADIR);(GAMMADIR);(PWD)) 220 ABSOSMAKEFILE := (shell(shell (shell(CD) (HSMAKEDIR)/(HSMAKEDIR)/(HSMAKEDIR)/(OSNAME);$(PWD))/build.make 221 else You can append line 216 to 215, e.g., 215 else ifeq ($(USINGMINGW), true) which eliminates some indentation and an endif, and I find easier to read. -John Done. Thanks for the review.
Tim
- Next message (by thread): Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]