RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS (original) (raw)

David Holmes david.holmes at oracle.com
Wed Jul 18 00:16:07 UTC 2012

On 18/07/2012 7:29 AM, Kelly O'Hair wrote:

On Jul 2, 2012, at 10:07 PM, David Holmes wrote:

Second this seems wrong:

"$(COMPILERMIC)" -classpath ... If COMPILERMIC is re-defined as "rmic " then the above will fail to execute. Plus didn't you already handle the spaces-in-paths problem in rules.make when you defined COMPILERMIC? I think COMPILERMIC is already defined to have quotes in it's definition, http://cr.openjdk.java.net/~tbell/7181175/webrev.00/make/windows/makefiles/rules.make.sdiff.html I don't think you need quotes here too.

I'm not sure if you are agreeing with me :) so to be clear. We have:

COMPILE_JAVAC="$(BootStrapDir)\bin\javac" $(BOOTSTRAP_JAVAC_FLAGS) COMPILE_RMIC="$(BootStrapDir)\bin\rmic"

at present. But if we were to change that to

COMPILE_RMIC="$(BootStrapDir)\bin\rmic" $(BOOTSTRAP_RMIC_FLAGS)

for example, then

"$(COMPILE_RMIC)" -classpath ...

would not work.

David

-kto

More information about the build-dev mailing list