RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS (original) (raw)

Volker Simonis volker.simonis at gmail.com
Wed Jul 18 17:38:55 UTC 2012

So I've just checked with MinGW and MKS. Removing the quotes around $(COMPILE_RMIC) in sa.make worked for me because, as Kelly noticed, COMPILE_RMIC is still quoted from its definition in rules.make. In this case I see the following output under MinGW (with VS2010 Express):

...Building sa-jdi.jar ...c:/Software/Java/jdk1.7.0_02\bin\javac -g -encoding ascii -source 6 -target 6 -classpath c:/Software/Java/jdk1.7.0_02/lib/tools.jar -d ../generated/saclasses .... warning: [options] bootstrap class path not set in conjunction with -source 1.6 Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 1 warning "c:/Software/Java/jdk1.7.0_02\bin\rmic" -classpath ../generated/saclasses -d ../generated/saclasses sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer echo sun.jvm.hotspot.runtime.VM.saBuildVersion=24.0-b01> ../generated/saclasses/sa.properties rm -f ../generated/saclasses/sun/jvm/hotspot/utilities/soql/sa.js

and under MKS (with VS2010 Express):

...Building sa-jdi.jar ...C:\Software\Java\jdk1.7.0_02in\javac -g -encoding ascii -source 6 -target 6 -classpath C:\Software\Java\jdk1.7.0_02/lib/tools.jar -d ../generated/saclasses .... warning: [options] bootstrap class path not set in conjunction with -source 1.6 Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 1 warning "C:\Software\Java\jdk1.7.0_02\bin\rmic" -classpath ../generated/saclasses -d ../generated/saclasses sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer echo sun.jvm.hotspot.runtime.VM.saBuildVersion=24.0-b01> ../generated/saclasses/sa.properties rm -f ../generated/saclasses/sun/jvm/hotspot/utilities/soql/sa.js

If I leave $(COMPILE_RMIC) quoted in sa.make, this still works (with double quotes in the output) but with the obvious problems mentioned by David. So I'd vote to remove the quoting in sa.make.

Regards, Volker

PS: here's the build command line I was using (sorry, but I think gmail is automatically wrapping the lines and I don't know how to prevent that):

make ARCH_DATA_MODEL=64 ALT_OUTPUTDIR=c:/Software/OpenJDK/output_amd64_z4_mingw ALT_FREETYPE_LIB_PATH=c:/Software/freetype-2.4.7/objs/win64/vc2010 ALT_FREETYPE_HEADERS_PATH=c:/Software/freetype-2.4.7/include ALT_BOOTDIR=c:/Software/Java/jdk1.7.0_02 ALLOW_DOWNLOADS=true ALT_MSVCRNN_DLL_PATH=c:/Software/OpenJDK/ALT_DROPS_DIR 2>&1 | tee c:/Software/OpenJDK/output_amd64_z4_mingw.log

On Wed, Jul 18, 2012 at 6:37 PM, Volker Simonis <volker.simonis at gmail.com> wrote:

That's a strange error. Which version of the makefiles did you use when you got that error - the ones from your webrev?

According to http://cr.openjdk.java.net/~tbell/7181175/webrev.00/make/windows/makefiles/rules.make.sdiff.html COMPILERMIC should be "$(BootStrapDir)\bin\rmic", but in your error log it is "c:/PROGRA1/Java/JDK171.00/bin/rmic" with all forward slashes. I remember that I had some trouble at that point as well when I did the initial change and quoting COMPILERMIC did help so I didn't thought about it any more. In my old build logs I can even see that I have double quotes at the place where COMPILERMIC is called. I'll retry locally and let you know if my build works without quoting COMPILERMIC. Regards, Volker On Wed, Jul 18, 2012 at 6:46 AM, Tim Bell <tim.bell at oracle.com> wrote: On 07/17/12 17:16, David Holmes wrote:

I'm not sure if you are agreeing with me :) so to be clear. We have: Thanks for the clarification. I think we all agree here, but best to be sure.

COMPILEJAVAC="$(BootStrapDir)\bin\javac" $(BOOTSTRAPJAVACFLAGS) COMPILERMIC="$(BootStrapDir)\bin\rmic" at present. Correct. This is in hotspot/make/windows/makefiles/rules.make But if we were to change that to COMPILERMIC="$(BootStrapDir)\bin\rmic" $(BOOTSTRAPRMICFLAGS) for example, then "$(COMPILERMIC)" -classpath ... would not work. Again, correct. Unfortunately, my efforts to do the logical thing are running off into the tall weeds: ######################################################################## ######################################################################## ##### Entering hotspot for target(s) allproduct ##### ######################################################################## _cd ./hotspot/make && _ make JDKTOPDIR=/d/tools/jdk8/7152336-closed/jdk JDKMAKESHAREDDIR=/d/tools/jdk8/7152336-closed/jdk/make/common/shared EXTERNALSANITYCONTROL=true SOURCELANGUAGEVERSION=7 TARGETCLASSVERSION=7 MILESTONE=internal BUILDNUMBER=b00 JDKBUILDNUMBER=b00 FULLVERSION=1.8.0-internal-tbbell201207162052-b00 PREVIOUSJDKVERSION=1.7.0 JDKVERSION=1.8.0 JDKMKTGVERSION=8 JDKMAJORVERSION=1 JDKMINORVERSION=8 JDKMICROVERSION=0 PREVIOUSMAJORVERSION=1 PREVIOUSMINORVERSION=7 PREVIOUSMICROVERSION=0 ARCHDATAMODEL=64 COOKEDBUILDNUMBER=0 ANTHOME="D:/APACHE~1.0" ALTOUTPUTDIR=D:/tools/jdk8/7152336-closed/windows-amd64/hotspot/outputdir ALTEXPORTPATH=D:/tools/jdk8/7152336-closed/windows-amd64/hotspot/import BUILDFLAVOR=product ALTSLASHJAVA="D:/java/" ALTBOOTDIR=C:/PROGRA1/Java/JDK171.00 ALTLANGTOOLSDIST=D:/tools/jdk8/7152336-closed/windows-amd64/langtools/dist allproduct INFO: ENABLEFULLDEBUGSYMBOLS=1 make[2]: Entering directory /d/tools/jdk8/7152336-closed/hotspot/make'_ _cd /d/tools/jdk8/7152336-closed/hotspot/make; \_ _make BUILDFLAVOR=product VMTARGET=product genericbuild2_ _ALTOUTPUTDIR=D:/tools/jdk8/7152336-closed/windows-amd64/hotspot/outputdir_ _INFO: ENABLEFULLDEBUGSYMBOLS=1_ _make[3]: Entering directory /d/tools/jdk8/7152336-closed/hotspot/make' mkdir -p D:/tools/jdk8/7152336-closed/windows-amd64/hotspot/outputdir _cd D:/tools/jdk8/7152336-closed/windows-amd64/hotspot/outputdir; _ MAKEFLAGS= MFLAGS= nmake -NOLOGO -f _/d/tools/jdk8/7152336-closed/hotspot/make/windows/build.make _ _Variant=compiler2 _ _WorkSpace=/d/tools/jdk8/7152336-closed/hotspot _ _BootStrapDir=/c/PROGRA1/Java/JDK171.00 _ _BuildUser=tbbell _ LP64=1 ARCH=x86 BUILDARCH=amd64 Platformarch=x86 Platformarchmodel=x8664 ENABLEFULLDEBUGSYMBOLS=1 ZIPDEBUGINFOFILES=1 RM="rm -f" ZIPEXE=zip JDKMKTGVERSION=8 JDKMAJORVER=1 JDKMINORVER=8 JDKMICROVER=0 JDKBUILDNUMBER=0 BUILDWINSA=1 JAVAHOME=/c/PROGRA1/Java/JDK171.00 OUTPUTDIR=/d/tools/jdk8/7152336-closed/windows-amd64/hotspot/outputdir GAMMADIR=/d/tools/jdk8/7152336-closed/hotspot MAKEVERBOSE=y HOTSPOTRELEASEVERSION=24.0-b14 JRERELEASEVERSION=1.8.0-internal-tbbell201207162052-b00 HOTSPOTBUILDVERSION= product mkdir windowsamd64compiler2 cd windowsamd64compiler2 nmake -nologo -f d:/tools/jdk8/7152336-closed/hotspot\make\windows\makefiles\top.make BUILDFLAVOR=product ARCH=x86 nmake in .\generated cd generated && c:\PROGRA2\MICROS2.0\VC\BIN\amd64\nmake.EXE -NOLOGO -f d:/tools/jdk8/7152336-closed/hotspot\make\windows\makefiles\generated.make DIR=.\generated BUILDFLAVOR=product mkdir -p ../generated/saclasses ...Building sa-jdi.jar ...c:/PROGRA1/Java/JDK171.00/bin/javac -g -encoding ascii -source 6 -target 6 -classpath c:/PROGRA1/Java/JDK171.00/lib/tools.jar -d ../generated/saclasses .... c:/PROGRA1/Java/JDK171.00/bin/rmic -classpath ../generated/saclasses -d ../generated/saclasses sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer echo sun.jvm.hotspot.runtime.VM.saBuildVersion=24.0-b14> ../generated/saclasses/sa.properties The system cannot find the path specified. NMAKE : fatal error U1077: 'echo' : return code '0x1' Stop. NMAKE : fatal error U1077: 'cd' : return code '0x2' Stop. NMAKE : fatal error U1077: 'c:\PROGRA2\MICROS2.0\VC\BIN\amd64\nmake.EXE' : return code '0x2' Stop. make[3]: *** [genericbuild2] Error 2 make[3]: Leaving directory /d/tools/jdk8/7152336-closed/hotspot/make'_ _make[2]: *** [product] Error 2_ _make[2]: Leaving directory /d/tools/jdk8/7152336-closed/hotspot/make' make[1]: *** [hotspot-build] Error 2 make[1]: Leaving directory `/d/tools/jdk8/7152336-closed' make: *** [buildproductimage] Error 2

More information about the build-dev mailing list