Patch to fix build breakage with GCC 4.7 (original) (raw)
Deepak Bhole dbhole at redhat.com
Thu Mar 1 00:03:06 UTC 2012
- Next message (by thread): Patch to fix build breakage with GCC 4.7
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
- David Holmes <david.holmes at oracle.com> [2012-02-29 18:49]:
Ah ok. Sorry, I haven't done much work with the build system before. Didn't realize that demo make files were run standalone.On 1/03/2012 9:43 AM, Deepak Bhole wrote: >* David Holmes<david.holmes at oracle.com> [2012-02-29 18:29]: >>>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ >> >>Where is ARCHFAMILY being set? >> > >It is set in make/common/shared/Platform.gmk
But that has no connection to the sample Makefiles.
In that case, a LIBARCH and OSNAME check there should suffice as the surrounding code uses those.
Deepak
David
>Deepak > >>David >> >> >>>If it is okay for push, please go ahead and push it (I don't have commit >>>access). I will then propose it for 7u. >>> >>>Thanks, >>>Deepak >>> >>>>David >>>>----- >>>> >>>>>The option seemed more like a relic from Solaris + SPARC config rather >>>>>than a requirement for Linux + SPARC. >>>> >>>> >>>> >>>>>Cheers, >>>>>Deepak >>>>> >>>>>>David >>>>>> >>>>>>On 31/01/2012 1:20 AM, Deepak Bhole wrote: >>>>>>>Hi, >>>>>>> >>>>>>>JDK builds currently fail with GCC 4.7 due to its stricter option >>>>>>>checking. >>>>>>> >>>>>>>GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain >>>>>>>files in JDK supply the -mimpure-text option to GCC. This option is only >>>>>>>valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build >>>>>>>on Linux (I suppose . >>>>>>> >>>>>>>This patch removes the option: >>>>>>>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >>>>>>> >>>>>>>1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >>>>>>>2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86002d64-Options.html >>>>>>> >>>>>>>If OK for push, please feel free to do so (I don't have commit access). >>>>>>> >>>>>>>Cheers, >>>>>>>Deepak
- Next message (by thread): Patch to fix build breakage with GCC 4.7
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]