Need reviewer on addition of whitespace normalizer script (original) (raw)

Dmitry Samersoff Dmitry.Samersoff at oracle.com
Fri Mar 2 08:06:54 UTC 2012

David,

On 2012-03-02 11:55, David Holmes wrote:

In what circumstances would a literal with an embedded tab be valid? AFAIK we should always be using /t.

It's a bad practice and probably we don't have such places in JDK, but it's perfectly valid for Java language and I see no reason to replace it forcibly.

-Dmitry

David -----

-Dmitry On 2012-03-02 01:32, Kelly O'Hair wrote:

Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers. 6625113: Add the normalize and rmkw perl script to the openjdk repository or openjdk site? http://cr.openjdk.java.net/~ohair/openjdk8/normalizer-script/webrev/ Probably a little history is warranted here. This script was originally written to normalize the whitespace in the jdk7 sources as they entered the Mercurial repositories in "changeset 0". It's been modified since then very slightly. I can't recall who wrote it (please speak up if you know) but it has been a valuable tool and I've had this CR to add it to the make/scripts directory for some time. The SCCS keyword removed (rmkw) was less useful, and I decided that it did not deserve being added. Why whitespace normalization? This was decided a long time ago when we had a raft of complaints from people viewing the sources with different tools and getting different views based on the TABs and trailing blanks or trailing newlines. So we decided to normalize on no TABs, no trailing blanks on lines, and no more than one blank line at the end of the file. This script was used to do that normalization. -kto

-- Dmitry Samersoff Java Hotspot development team, SPB04

More information about the build-dev mailing list