Need reviewer: corba changes for build infra (original) (raw)

Fredrik Öhrström fredrik.ohrstrom at oracle.com
Tue Mar 13 09:08:06 UTC 2012

2012-03-13 06:30, Tim Bell skrev:

Sorry, I meant to pick on these lines, and also mention that args.length should be an even number at line 64... 107 infiles.add(args[i]); 108 outfiles.add(args[i]); Otherwise, my remarks apply, FWIW. You are right, the old behavior of the makefiles were to copy the source and then strip it. Therefore the destructive rewriting of the file.

The new behavior is to strip a source and write a destination at the same time. The new makefiles use only the @file so it uses the correct code. This is now the same behavior as the other Strip/CompileProperties implementations in the langtools and jdk repos.

I suggest we remove the old dangerous option of not using an @file.

Eventually we will merge all (slightly different) StripProperties and CleanProperties implementations into a single location. But this change is the first step, ie to have them accept the same command line options.

//Fredrik

More information about the build-dev mailing list