Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built (original) (raw)

Fredrik Öhrström fredrik.ohrstrom at oracle.com
Tue Mar 13 10:01:25 UTC 2012

2012-03-13 00:26, David Holmes skrev:

You seem to have included the MINIMAL VM changes in here. Those changes have not been pushed to the mainline and are not yet to be pushed. If you want to push these build-infra changes you will need to factor out the MINIMAL VM stuff - else wait.

The change of a few makefile internal variables named, for example KERNEL_VM_TARGETS to MINIMAL_VM_TARGETS makes sense, since the configure generated variables are already named JVM_VARIANT_MINIMAL. This change is based on a decision to rename kernel to minimal, that will eventually arrive, as you say. I see no harm in these changes being pushed now. It will not affect anyone since the actual makefile api (targets) are still called kernel.

//Fredrik

More information about the build-dev mailing list