RFR: 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx] (original) (raw)

Fredrik Öhrström fredrik.ohrstrom at oracle.com
Thu Mar 15 19:57:12 UTC 2012


----- stuart.marks at oracle.com skrev:

I don't know, and I don't have the expertise in the build system to know how other LANG settings would affect the build. Perhaps somebody else on build-dev knows. Meanwhile, we're patching things up this way, even though it makes things a bit messier.

If you had built the new build-infra/jdk8 tree, you would have noticed that it does not require you to set LANG=C It should work with any locale, I use my default setting LANG=sv_SE.UTF-8

The reason LANG=C is necessary for the old makefiles is because in very few places in the makefiles, tr,date,sort and some other cli tools, are used in such a way that is dependent on the locale. Also these commands generate Java source or other settings which cause the actual error message to appear much later, and it takes a bit of time to track it back to the original cause, which is in fact trivial to fix.

//Fredrik



More information about the build-dev mailing list