RFR: JDK-8029908: jdk 8u5 mac build produces incorrect version string 1.8.0_5 (original) (raw)
Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Sat Dec 14 19:56:33 UTC 2013
- Previous message (by thread): RFR: JDK-8029908: jdk 8u5 mac build produces incorrect version string 1.8.0_5
- Next message (by thread): hg: jdk8/build/jdk: 8027709: JDK8 docs on -XX:CompileOnly option are incorrect
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2013-12-13 10:07, Erik Joelsson wrote:
Hello,
Please review this simple little workaround for jdk-update-version. On macosx 10.7, the expr command is broken and the following will not work as on other platforms (or macosx 10.8): expr "--with-update-version=05" : '[^=]*=(.*)' On the other platforms, this will return "05" but on 10.7 it returns "5". Autoconf uses this construct to parse command line parameters. Because of this, we are unable to assign the value "05" to --jdk-update-version. Since in the build, we always treat the update version as 2 digits, the simple workaround is to zero pad the value for this variable if it is only one character long. Webrev: http://cr.openjdk.java.net/~erikj/8029908/webrev.root.01/
Looks good to me.
/Magnus
- Previous message (by thread): RFR: JDK-8029908: jdk 8u5 mac build produces incorrect version string 1.8.0_5
- Next message (by thread): hg: jdk8/build/jdk: 8027709: JDK8 docs on -XX:CompileOnly option are incorrect
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]