Review Request: 8007524: build-infra: Incremental build of tools.jar broken (original) (raw)
Tim Bell tim.bell at oracle.com
Tue Feb 5 15:16:14 UTC 2013
- Previous message (by thread): Review Request: 8007524: build-infra: Incremental build of tools.jar broken
- Next message (by thread): hg: jdk8/build: 8007524: build-infra: Incremental build of tools.jar broken
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Erik:
The logic for setting up correct dependencies from class files to jar files in the macro SetupArchive is broken. This fixes two things. The wrong variable was used to filter files found and a ',' was missing in the macro call to CacheFind. Verifed that dependency list is now populated instead of empty as before, and that changing a class in javac caused tools.jar to be updated.
Looks good. That was a very subtle fix.
Tim
- Previous message (by thread): Review Request: 8007524: build-infra: Incremental build of tools.jar broken
- Next message (by thread): hg: jdk8/build: 8007524: build-infra: Incremental build of tools.jar broken
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]