XS RFR: 8008424: Isolate PROFILE make variable from incidental setting in the environment (original) (raw)

David Holmes david.holmes at oracle.com
Tue Feb 19 02:36:00 UTC 2013


A very simple follow up fix for the Profiles work that prevents a conflict between an unrelated environment variable and the make variable:

http://cr.openjdk.java.net/~dholmes/8008424/webrev/

Inline:

--- old/makefiles/BuildJdk.gmk 2013-02-18 21:32:55.022943673 -0500 +++ new/makefiles/BuildJdk.gmk 2013-02-18 21:32:53.698869592 -0500 @@ -91,10 +91,11 @@ +$(MAKE) -f CopySamples.gmk

Create the final jdk and jre images, to be wrapped up

-# into packages, or installed. +# into packages, or installed. Ensure PROFILE is not set +# in these cases. images: - +$(MAKE) -f CreateJars.gmk - +$(MAKE) -f Images.gmk + +$(MAKE) PROFILE="" -f CreateJars.gmk + +$(MAKE) PROFILE="" -f Images.gmk ifeq ($(OPENJDK_TARGET_OS), macosx) +$(MAKE) -f Bundles.gmk endif

Thanks, David



More information about the build-dev mailing list