8008977: profiles build broken by Nashorn build changes (original) (raw)

David Holmes david.holmes at oracle.com
Tue Feb 26 20:29:02 UTC 2013

Alan,

Thanks for diving onto this. I can't say I understand what changed in detail yet but I know that there are places where I had to jump through hoops to deal with $ in class names appropriately. I would not be surprised if there is further breakage if somehow this expansion mechanism has changed.

David

On 26/02/2013 11:48 PM, Alan Bateman wrote:

The build changes for Nashorn were pushed to jdk8/tl yesterday and one of the casualties is the profiles build. My reading of the make file changes is that ListPathsSafelyIf (defined in MakeBase.gmk) has changed the expansion so that secondary expansion is no longer required. Erik is away this week but I assume this was intentional. Attached is the diffs that I propose to push to jdk8/tl today to get profiles building again, assuming I get a reviewer. -Alan

diff --git a/makefiles/profile-rtjar-includes.txt b/makefiles/profile-rtjar-includes.txt --- a/makefiles/profile-rtjar-includes.txt +++ b/makefiles/profile-rtjar-includes.txt @@ -349,6 +349,7 @@ _com/sun/rowset/providers _ _com/sun/script/javascript _ _com/sun/script/util _ _+ com/sun/security/auth _ _com/sun/security/auth/callback _ _com/sun/security/auth/login _ _com/sun/security/auth/module _ @@ -448,8 +449,7 @@ _sun/tracing _ sun/tracing/dtrace _-PROFILE3RTJARINCLUDETYPES := _ - com/sun/security/auth/*.class +PROFILE3RTJARINCLUDETYPES := _PROFILE3RTJAREXCLUDETYPES := _ _javax/management/remote/rmi/RMIConnectionImplTie.class _ @@ -457,10 +457,10 @@ _javax/management/remote/rmi/RMIServerImplTie.class _ _javax/management/remote/rmi/RMIServerStub.class _ _com/sun/security/auth/callback/DialogCallbackHandler.class _ _- com/sun/security/auth/callback/DialogCallbackHandler$$$$1.class _ _- com/sun/security/auth/callback/DialogCallbackHandler$$$$2.class _ - _com/sun/security/auth/callback/DialogCallbackHandler$$$$Action.class _ - com/sun/security/auth/callback/DialogCallbackHandler$$$$ConfirmationInfo.class _+ com/sun/security/auth/callback/DialogCallbackHandler$$1.class _ _+ com/sun/security/auth/callback/DialogCallbackHandler$$2.class _ _+ com/sun/security/auth/callback/DialogCallbackHandler$$Action.class _ + com/sun/security/auth/callback/DialogCallbackHandler$$ConfirmationInfo.class _PROFILE3INCLUDEMETAINFSERVICES := _ META-INF/services/javax.script.ScriptEngineFactory

More information about the build-dev mailing list