RFR: Allow using a system installed libpng (original) (raw)
Omair Majid omajid at redhat.com
Mon Feb 3 20:44:41 UTC 2014
- Previous message (by thread): RFR: Allow using a system installed libpng
- Next message (by thread): RFR: Allow using a system installed libpng
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
- Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> [2014-02-03 14:42]:
On 2014-02-03 18:43, Omair Majid wrote: >Hi, > >The following webrevs modify the build system to allow building against >the system-installed copy of libpng as well as using the bundled copy of >libpng > >ROOT: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01/ >JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/01-jdk/ > >A new configure option
--with-libpngis introduced which defaults to >bundledbut can be set tosystemto use the system-installed copy of >libpng. Thank you for the patch! Looks good to me (but I'm no formal reviewer), apart from this line in libraries.m4: withlibpng=${DEFAULTlibpng} which should be DEFAULTLIBPNG, I assume, otherwise the default case will not work.
Whoops. Updated webrevs: root: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02/ jdk: http://cr.openjdk.java.net/~omajid/webrevs/system-libpng/02-jdk/
Due to this, I'd like to ask you to please double check that --with-libpng=system | bundled | invalid-value | , and no flag at all, all work as expected.
I re-ran all these 4 options. system builds with system, bundled and build a bundled copy and invalid-value fails during configure.
Thanks, Omair
-- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
- Previous message (by thread): RFR: Allow using a system installed libpng
- Next message (by thread): RFR: Allow using a system installed libpng
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]