RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling (original) (raw)

Alexander Smundak asmundak at google.com
Wed Dec 2 22:02:35 UTC 2015

On Wed, Dec 2, 2015 at 1:38 PM, Andrew Hughes <gnu.andrew at redhat.com> wrote:

snip...

The new revision does that: http://cr.openjdk.java.net/~asmundak/8073139/hotspot/webrev.03 http://cr.openjdk.java.net/~asmundak/8073139/jdk/webrev.03 http://cr.openjdk.java.net/~asmundak/8073139/root/webrev.03/ This has grown a lot from my version. I guess you are referring to the three additional files under hotspot/agent.

The main change seems to be in having to handle a ppc64le define in numerous places, which seems unnecessary as ppc64 is present there. The version I'm looking at that we used in 8 deliberately avoids this by forcing ARCH back to ppc64 on ppc64le. Was there a reason not to do that? I think fiddling with ARCH is fragile. IMHO it's easier to have ppc64le checked explicitly in the agent.

More information about the build-dev mailing list