RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling (original) (raw)

David Holmes david.holmes at oracle.com
Tue Dec 8 04:46:42 UTC 2015

On 8/12/2015 1:44 PM, Alexander Smundak wrote:

It is achievable by adding a small ppc-specific check to the common/autoconf/platform.m4:

@@ -282,6 +282,8 @@ elif test "x$OPENJDKTARGETOS" != xmacosx && test "x$OPENJDKTARGETCPU" = xx8664; then # On all platforms except MacOSX replace x8664 with amd64. OPENJDKTARGETCPULEGACY="amd64" + elif test "x$OPENJDKTARGETCPU" = xppc64le; then + OPENJDKTARGETCPULEGACY="ppc64" fi ACSUBST(OPENJDKTARGETCPULEGACY) However, there is a code in make/Images.gmk using OPENJDKTARGETCPULEGACY $(call info-file-item, "OSARCH", "$(OPENJDKTARGETCPULEGACY)") so that the 'release' file in the image directory will now have JAVAVERSION="9" JAVAFULLVERSION="9-internal+0-2015-12-07-190811.asmundak.hs-rt" OSNAME="Linux" OSVERSION="2.6" OSARCH="ppc64" ^^^^^^^^ SOURCE=.., instead of "ppc64le". If someone can tell me which other variable I should use to achieve that without changing the contents of the 'release' file on other platforms, I'll be grateful.

Okay never mind - and thanks for looking into this. I see now this is set via:

./autoconf/flags.m4: COMMON_CCXXFLAGS_JDK="$COMMON_CCXXFLAGS_JDK -DARCH='"$OPENJDK_TARGET_CPU_LEGACY"' -D$OPENJDK_TARGET_CPU_LEGACY"

so there is no way to add a second value without introducing some additional variable. At the hotspot level it could be handled differently if we had a platform_ppc64le file, as it could just be added to the SYSDEFS.

Thanks, David

More information about the build-dev mailing list