RFR(XS) : 8144695 : --disable-warnings-as-errors does not work for HotSpot build (original) (raw)

Igor Ignatyev igor.ignatyev at oracle.com
Thu Dec 17 13:22:28 UTC 2015

On Dec 17, 2015, at 2:10 AM, Kim Barrett <kim.barrett at oracle.com> wrote:

On Dec 16, 2015, at 5:54 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:

as Mikael V correctly pointed out, there is missed $( ) in solaris/adlc. here is the new webrev: http://cr.openjdk.java.net/~iignatyev/8144695/webrev.01/ I wonder why the value for WARNINGSAREERRORS isn't obtained from the configure-provided variable CFLAGSWARNINGSAREERRORS? E.g. something like WARNINGSAREERRORS ?= $(CFLAGSWARNINGSAREERRORS) There may be a good reason for that, and thinking about it is probably better done as a separate RFE. Doing so might simplify things by allowing the assignment to be moved to some higher level common point. [The bsd conditionalization on $(COMPILERWARNINGSFATAL) might make that hard. Where does that variable come from? I haven't looked for anything similar elsewhere.] ------------------------------------------------------------------------------ make/solaris/makefiles/adlc.make 77 WARNINGSAREERRORS ?= -w -xwe I'm pretty sure "-w" is wrong here, and should be removed. you are right, I made a typo, it was ‘+w’ before. the new webrev : http://cr.openjdk.java.net/~iignatyev/8144695/webrev.02/

And it's not clear why this assignment should be conditional on the compiler version. it was added as a fix for https://bugs.openjdk.java.net/browse/JDK-6851829, excerpt from Chris’s evaluation:

Since some of the errors are in system headers we can only disable the "+w -errwarn" on SS11 and below.

More information about the build-dev mailing list