RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds. (original) (raw)

Bob Vandette bob.vandette at oracle.com
Thu Dec 17 16:48:29 UTC 2015

  1. In make/bsd/makefiles/vm.make

You commented out the libffi logic that we’ll need to Zero iOS ARM. I guess we could uncomment this with the push to add this support.

  1. hotspot/src/share/vm/runtime/java.cpp

You shouldn’t need this change. dll_lookup does the right thing for static builds now.

661 #ifndef STATIC_BUILD

662 void *lib_handle = os::native_java_library();

663 func = CAST_TO_FN_PTR(jdk_version_info_fn_t,

664 os::dll_lookup(lib_handle, "JDK_GetVersionInfo0"));

665 #else 666 extern jdk_version_info_fn_t JDK_GetVersionInfo0; 667 func = CAST_TO_FN_PTR(jdk_version_info_fn_t, 668 &JDK_GetVersionInfo0); 669 #endif

  1. jdk/src/java.base/unix/native/libnio/ch/Net.c

Can you check to see that all of these changes are really necessary?

Bob.

On Dec 17, 2015, at 8:19 AM, Gary Adams <gary.adams at oracle.com> wrote:

I've revised the original webrev based on some feedback received. - reverted white space only changes - proper copyrights on the new files - some hotspot files contained previously removed code Webrev; http://cr.openjdk.java.net/~gadams/8145132/webrev.01/ Planning to push this first batch tomorrow. On 12/11/15 10:15, Gary Adams wrote: Here's the initial upload of changes that provides support for the ios and android ports for the mobile/dev repos. While there have been some preliminary reviews of the code, there is still more work required before we will look for more thorough reviews and an integration to mobile/jdk9 repos.

Issue: https://bugs.openjdk.java.net/browse/JDK-8145132 Webrev: http://cr.openjdk.java.net/~gadams/8145132/webrev.00/

Here's a simple configure script to generate a ios-x8664 build for use with the iphone simulator. (uses homebrew 64 bit freetype from pkgconfig) export JAVAHOME=/usr/libexec/javahome -v 1.8 export PATH=$JAVAHOME/bin:~/homebrew/bin:$PATH _bash ../../configure _ _--openjdk-target=x8664-macos-ios _ _--with-boot-jdk=$JAVAHOME _ _--disable-warnings-as-errors _ _--disable-headful _ _--enable-static-build=yes _ --with-jvm-variants=minimal1 Also, tested with i586-macos-ios target for 32 bit with a locally built --with-freetype 2.6.2.

More information about the build-dev mailing list