RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition (original) (raw)

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Dec 18 12:40:21 UTC 2015

On 2015-12-16 14:50, Magnus Ihse Bursie wrote:

There is an interest from the community to build OpenJDK using Visual Studio 2015 Community edition.

This patch is provided by Timo Kinnunen <timo.kinnunen at gmail.com>. I am sponsoring this patch. The changes to the source code files are mostly casts to uintptrt, but there are some other changes as well. I'm not quite sure who's the owner of all these files. If I'm missing some group, please help me and forward the mail to them. Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01 /Magnus

Kumar had a reply to this which unfortunately ended up on a different thread on which the component teams were not cc'ed. Here are the relevant parts:

On 12/16/2015 12:18 PM, Magnus Ihse Bursie wrote: On 2015-12-16 16:33, Kumar Srinivasan wrote:

Hello,

http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01/jdk/src/jdk.pack200/share/native/common-unpack/utils.h.udiff.html

You are undefining Windows math.h OVERFLOW, what is it defined as ? With you redefining this, will it cause problems for users of this API, likely to affect JNI apps. Probably need to redefine the pack200 OVERFLOW constant to something else, probably PACK200OVERFLOW to prevent namespace collisions. I agree, this is a better solution. I've updated the webrev with this solution (although I used the name PSIZEOVERFLOW to align with PSIZEMAX). http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.02 /Magnus

/Magnus

More information about the build-dev mailing list