RFR: JDK-8146002: Need to support mirrors for bootstrapping Jib (original) (raw)

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Dec 23 15:48:53 UTC 2015

Looks good to me.

/Magnus

22 dec. 2015 kl. 17:50 skrev Erik Joelsson <erik.joelsson at oracle.com>:

Right, new webrev: http://cr.openjdk.java.net/~erikj/8146002/webrev.03/ /Erik

On 2015-12-22 17:43, Magnus Ihse Bursie wrote: Nice. Just one thing more: please save and restore the old value of IFS. Things can behave strange when modifying IFS so it's good to have it changed for as short a period as possible.

/Magnus

22 dec. 2015 kl. 15:33 skrev Erik Joelsson <erik.joelsson at oracle.com>:

Thanks for fast review! Added IFS and verified that it accepts any combination of space and comma as separator. Webrev: http://cr.openjdk.java.net/~erikj/8146002/webrev.02/ /Erik

On 2015-12-22 15:23, Magnus Ihse Bursie wrote: If you set IFS=' ,' before looping over the jibmirrors variable, you will allow a comma-separated list as well as a space separated, which makes it possible to set using environment variables in a reasonable way. I think. :) I always have to look up the details on IFS.

Otherwise it's looking fine. /Magnus

22 dec. 2015 kl. 15:13 skrev Erik Joelsson <erik.joelsson at oracle.com>:

Hello, If we are to rely on Jib, the whole process needs redundancy in download locations. For the main downloads, this is already in place, but the weak link is the initial bootstrapping of the tool itself. I propose to add support in common/bin/jib.sh for checking a list of mirrors to download the install script from. Bug: https://bugs.openjdk.java.net/browse/JDK-8146002 Webrev: http://cr.openjdk.java.net/~erikj/8146002/webrev.01/ /Erik

More information about the build-dev mailing list