RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file (original) (raw)
Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Mar 7 09:21:44 UTC 2017
- Previous message (by thread): RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file
- Next message (by thread): RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me.
/Magnus
On 2017-03-07 09:51, Erik Joelsson wrote:
Hello,
The jmods for the imported javafx modules end up with imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed JDK-8176264 to address this properly. For the immediate problem I instead propose this simple patch to the jmod creation. I have verified that the jmods no longer contain any touch files from the build. Bug: https://bugs.openjdk.java.net/browse/JDK-8176172 Patch: diff -r 4d29ee32d926 make/CreateJmods.gmk --- a/make/CreateJmods.gmk +++ b/make/CreateJmods.gmk @@ -139,7 +139,7 @@ _--os-arch $(OPENJDKTARGETCPULEGACY) _ _--os-version $(REQUIREDOSVERSION) _ _--module-path $(JMODSDIR) _ - --exclude _'{the.,.diz,.debuginfo,.dSYM/,.dSYM,.pdb,.map}' _ + --exclude _'**{the.,.marker,.diz,.debuginfo,.dSYM/**,.dSYM,.pdb,*.map}' _ $(JMODFLAGS) (JMODSTEMPDIR)/(JMODSTEMPDIR)/(JMODSTEMPDIR)/(notdir $@) $(MV) (JMODSTEMPDIR)/(JMODSTEMPDIR)/(JMODSTEMPDIR)/(notdir @)@) @)@ /Erik
- Previous message (by thread): RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file
- Next message (by thread): RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]