RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file (original) (raw)
Mandy Chung mandy.chung at oracle.com
Tue Mar 7 16:27:03 UTC 2017
- Previous message (by thread): RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file
- Next message (by thread): RFR: JDK-8176271: Still unable to build JDK 9 on some *7 sparcs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
This fix looks okay.
Mandy
On Mar 7, 2017, at 12:51 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
Hello, The jmods for the imported javafx modules end up with imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed JDK-8176264 to address this properly. For the immediate problem I instead propose this simple patch to the jmod creation. I have verified that the jmods no longer contain any touch files from the build. Bug: https://bugs.openjdk.java.net/browse/JDK-8176172 Patch: diff -r 4d29ee32d926 make/CreateJmods.gmk --- a/make/CreateJmods.gmk +++ b/make/CreateJmods.gmk @@ -139,7 +139,7 @@ _--os-arch $(OPENJDKTARGETCPULEGACY) _ _--os-version $(REQUIREDOSVERSION) _ _--module-path $(JMODSDIR) _ _- --exclude '{the.,.diz,.debuginfo,.dSYM/,.dSYM,.pdb,.map}' _ _+ --exclude '**{the.,.marker,.diz,.debuginfo,.dSYM/**,.dSYM,.pdb,*.map}' _ $(JMODFLAGS) (JMODSTEMPDIR)/(JMODSTEMPDIR)/(JMODSTEMPDIR)/(notdir $@) $(MV) (JMODSTEMPDIR)/(JMODSTEMPDIR)/(JMODSTEMPDIR)/(notdir @)@) @)@ /Erik
- Previous message (by thread): RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file
- Next message (by thread): RFR: JDK-8176271: Still unable to build JDK 9 on some *7 sparcs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]