RFR: JDK-8172312 Update docs target and image for new combined docs (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Fri Mar 31 08:02:27 UTC 2017
- Previous message (by thread): RFR: JDK-8172312 Update docs target and image for new combined docs
- Next message (by thread): RFR: JDK-8172312 Update docs target and image for new combined docs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good to me.
My suggestion was to to add the rmic dirs to those variables in Javadoc.gmk, but your solution is even better. I didn't realize that you could just add to a "pathlist" with another call to PathList, so I thought we had to get at the variables that GetModuleSrcPath uses as input. Anyway, very nice to not have to duplicate the list of source dirs anymore.
/Erik
On 2017-03-30 22:17, Magnus Ihse Bursie wrote:
On 2017-03-30 21:19, Magnus Ihse Bursie wrote:
New webrev coming up soon... Here it is: http://cr.openjdk.java.net/~ihse/JDK-8172312-combined-javadocs/webrev.02 Changes since last webrev: * Removed java.base from DOCSMODULES and updated comment. * Removed jdk.crypto.mscapi and jdk.crypto.ucrypto from DOCSMODULES. * Replaced JAVADOCSOURCEDIRS with _JAVADOCSOURCEPATH := (callPathList,(call PathList, (callPathList,(call GetModuleSrcPath) _ $(SUPPORTOUTPUTDIR)/rmic/* $(JDKTOPDIR)/src/*/share/doc/stub) and added it to JAVADOCVARDEPS * Fixed JAVADOCTOP indentation * Removed java.base from list of modules for reference javase javadoc * Updated REFERENCETARGETDIR to $(IMAGESOUTPUTDIR)/javase-docs/api /Magnus
- Previous message (by thread): RFR: JDK-8172312 Update docs target and image for new combined docs
- Next message (by thread): RFR: JDK-8172312 Update docs target and image for new combined docs
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]