RFR: JDK-8199782: Fix compilation warnings detected by Solaris Developer Studio 12.6 (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Thu Apr 5 00:05:43 UTC 2018

On 2018-04-04 17:00, David Holmes wrote:

Hi Gary,

On 5/04/2018 4:18 AM, Gary Adams wrote: Getting the sources ready for the next Solaris developer studio toolchain.

Issue: https://bugs.openjdk.java.net/browse/JDK-8199782 Webrev: http://cr.openjdk.java.net/~gadams/8199782/webrev.00/ This update conditionally disables some new error checks, if the new toolchain is used. This looks odd:  _231     DISABLEDWARNINGSsolstudio := $(DISABLEDWARNINGSsolstudio), _ as it is self-referential. Should you use a different variable name? Is there an issue if this variable has not been set? This construct may look a bit weird but is fine. The named parameter will get translated behind the scenes to BUILD_LIBJVM_DISABLED_WARNINGS_solstudio so it's not actually self referential (and even if it was, it would still work as expected, even if it looks a bit weird).

/Erik

Otherwise seems okay.

Thanks, David

More information about the build-dev mailing list