Zero fails to build on SPARC again, similar to JDK-8186578 (original) (raw)
David Holmes david.holmes at oracle.com
Tue Apr 10 11:34:05 UTC 2018
- Previous message (by thread): RFR: 8201357: ALSA_CFLAGS is needed; was dropped in JDK-8071469
- Next message (by thread): Zero fails to build on SPARC again, similar to JDK-8186578
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Adding in build-dev. I think the build guys need to help you figure this out.
Cheers, David
On 10/04/2018 9:21 PM, John Paul Adrian Glaubitz wrote:
On 04/10/2018 01:00 PM, John Paul Adrian Glaubitz wrote:
Trying to add the necessary source there now. Hmm, I tried various ways of adding it now: diff -r a47d1e21b3f1 make/hotspot/lib/CompileGtest.gmk --- a/make/hotspot/lib/CompileGtest.gmk Thu Apr 05 10:54:53 2018 +0200 +++ b/make/hotspot/lib/CompileGtest.gmk Tue Apr 10 14:15:36 2018 +0300 @@ -52,6 +52,14 @@ $(call create-mapfile) endif +ifeq ($(call check-jvm-feature, zero), true) + JVMCFLAGSFEATURES += -DZERO -DCCINTERP -DZEROLIBARCH='"$(OPENJDKTARGETCPULEGACYLIB)"' $(LIBFFICFLAGS) + JVMLIBSFEATURES += $(LIBFFILIBS) + ifeq ($(OPENJDKTARGETCPU), sparcv9) + BUILDLIBJVMEXTRAFILES := $(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp + endif +endif + # Disabling undef, switch, format-nonliteral and tautological-undefined-compare # warnings for clang because of test source. @@ -71,7 +79,8 @@ _EXCLUDES := $(JVMEXCLUDES), _ _EXCLUDEFILES := gtestLauncher.cpp, _ _EXCLUDEPATTERNS := $(JVMEXCLUDEPATTERNS), _ _- EXTRAFILES := $(GTESTFRAMEWORKSRC)/src/gtest-all.cc, _ _+ EXTRAFILES := $(GTESTFRAMEWORKSRC)/src/gtest-all.cc _ + _$(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp, _ _EXTRAOBJECTFILES := (filter−out(filter-out %/operatornew(filter−out(OBJSUFFIX), _ _$(BUILDLIBJVMALLOBJS)), _ _CFLAGS := (JVMCFLAGS)−I(JVMCFLAGS) -I(JVMCFLAGS)−I(GTESTFRAMEWORKSRC) _ @@ -109,7 +118,8 @@ _NAME := gtestLauncher, _ _TYPE := EXECUTABLE, _ _OUTPUTDIR := $(JVMOUTPUTDIR)/gtest, _ _- EXTRAFILES := $(GTESTLAUNCHERSRC), _ _+ EXTRAFILES := $(GTESTLAUNCHERSRC) _ + _$(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp, _ _OBJECTDIR := $(JVMOUTPUTDIR)/gtest/launcher-objs, _ _CFLAGS := (JVMCFLAGS)−I(JVMCFLAGS) -I(JVMCFLAGS)−I(GTESTFRAMEWORKSRC) _ _-I$(GTESTFRAMEWORKSRC)/include, _ diff -r a47d1e21b3f1 make/hotspot/lib/CompileJvm.gmk --- a/make/hotspot/lib/CompileJvm.gmk Thu Apr 05 10:54:53 2018 +0200 +++ b/make/hotspot/lib/CompileJvm.gmk Tue Apr 10 14:15:36 2018 +0300 @@ -197,6 +197,14 @@ endif endif +ifeq ($(call check-jvm-feature, zero), true) + JVMCFLAGSFEATURES += -DZERO -DCCINTERP -DZEROLIBARCH='"$(OPENJDKTARGETCPULEGACYLIB)"' $(LIBFFICFLAGS) + JVMLIBSFEATURES += $(LIBFFILIBS) + ifeq ($(OPENJDKTARGETCPU), sparcv9) + BUILDLIBJVMEXTRAFILES := $(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp + endif +endif + ifeq ($(OPENJDKTARGETOS), windows) ifeq ($(OPENJDKTARGETCPUBITS), 64) RCDESC := 64-Bit$(SPACE) It does build it, but the build system is unable to find the object files: glaubitz at deb4g:/srv/glaubitz/hs$ find . -name "memsetwithconcurrentreaderssparc.o" ./build/linux-sparcv9-normal-zero-release/hotspot/variant-zero/libjvm/gtest/objs/memsetwithconcurrentreaderssparc.o ./build/linux-sparcv9-normal-zero-release/hotspot/variant-zero/libjvm/gtest/launcher-objs/memsetwithconcurrentreaderssparc.o glaubitz at deb4g:/srv/glaubitz/hs$ Adrian
- Previous message (by thread): RFR: 8201357: ALSA_CFLAGS is needed; was dropped in JDK-8071469
- Next message (by thread): Zero fails to build on SPARC again, similar to JDK-8186578
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]