Zero fails to build on SPARC again, similar to JDK-8186578 (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Tue Apr 10 18:04:39 UTC 2018
- Previous message (by thread): Zero fails to build on SPARC again, similar to JDK-8186578
- Next message (by thread): Zero fails to build on SPARC again, similar to JDK-8186578
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2018-04-10 10:50, John Paul Adrian Glaubitz wrote:
Hi Erik!
On 04/10/2018 06:54 PM, Erik Joelsson wrote: I've found the problem. In JvmFeatures.gmk we have:
ifeq ($(call check-jvm-feature, zero), true) JVMCFLAGSFEATURES += -DZERO -DCCINTERP -DZEROLIBARCH='"$(OPENJDKTARGETCPULEGACYLIB)"' $(LIBFFICFLAGS) JVMLIBSFEATURES += $(LIBFFILIBS) ifeq ($(OPENJDKTARGETCPU), sparcv9) BUILDLIBJVMEXTRAFILES := $(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp endif endif The BUILDLIBJVMEXTRAFILES is implicitly trying to set the EXTRAFILES argument to the BUILDLIBJVM SetupNativeCompilation call. This used to work because there was no setting of that parameter in the actual call. In a recent change, that parameter is not set to something else, overriding the assignment above. Aha! Do you happen to know which change was responsible for that? Then I can adjust the bug summary accordingly. "JDK-8201236 Straighten out dtrace build logic" To fix this, you need to add $(BUILDLIBJVMEXTRAFILES) to the EXTRAFILES line in CompileJvm.gmk. Indeed, this fixes it! Thanks so much, I was already about to give up ;). We should have been explicit with that parameter in the first place, then Magnus would not have missed it. Glad I could help.
/Erik
Adrian
- Previous message (by thread): Zero fails to build on SPARC again, similar to JDK-8186578
- Next message (by thread): Zero fails to build on SPARC again, similar to JDK-8186578
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]