RFR: 8201360: Zero fails to build on linux-sparc after 8201236 (original) (raw)
Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Apr 10 20:01:43 UTC 2018
- Previous message (by thread): RFR: 8201360: Zero fails to build on linux-sparc after 8201236
- Next message (by thread): RFR: 8201360: Zero fails to build on linux-sparc after 8201236
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2018-04-10 20:22, John Paul Adrian Glaubitz wrote:
Hi!
Please review this minor change which fixes the Zero build on linux-sparc which got broken after "JDK-8201236 Straighten out dtrace build logic". While I agree that the fix solves your problems, maybe you could delay pushing this for a while?
The regression you noted was not caused by JDK-8201236, but by JDK-8198862 "Stop doing funky compilation stuff for dtrace". In fact, JDK-8201236 (which is pushed to jdk/jdk but not yet integrated into jdk/hs, apparently) will once again remove EXTRA_FILES from the SetupNativeCompilation, making zero work again.
So if you just wait until JDK-8201236 moves into jdk/hs, this will be fixed. Otherwise, you're just creating a merge conflict for the integrator. :(
/Magnus
The change affects the Zero build on linux-sparc only since SPARC has its _own implementation of memsetwithconcurrentreaders() in memsetwith_ concurrentreaderssparc.cpp which needs to be added to $(EXTRAFILES) by adding (BUILDLIBJVMEXTRAFILES)to(BUILDLIBJVMEXTRAFILES) to (BUILDLIBJVMEXTRAFILES)to(EXTRAFILES).
Thanks, Adrian
- Previous message (by thread): RFR: 8201360: Zero fails to build on linux-sparc after 8201236
- Next message (by thread): RFR: 8201360: Zero fails to build on linux-sparc after 8201236
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]