RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols (original) (raw)

Phil Race philip.race at oracle.com
Wed Apr 11 15:40:27 UTC 2018

Yes, I think this should be removed for AIX as we have done for Solaris + Linux, and I could have done that but I also had no way to test it .. without that capability I ran more risk of breaking AIX than fixing a problem that apparently hasn't been seen there. I am not sure if headful tests are regularly run on AIX, although email from earlier this week from IBM offering to contribute some input method support for AIX strongly suggests that it is of interest :-)

-phil.

On 04/11/2018 01:17 AM, Severin Gehwolf wrote:

On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote:

LIBSaix := -lawtheadless, I guess that AIX team should have a similar fix. Possibly. I have no way of testing it, though. So will leave it to AIX folk to have a look. My experience was that it isn't easily reproducible. Some observations: 1. Run swing app such as SwingSet2 on a headfull system. Since fontmanager will have a link dep on lawtheadless, and awt code loads libawtxawt (headfull) on a headfull system, both libraries providing symbols needed by libfontmanager will be loaded. Then it depends whether this is a problem on that particular system or not. In my experience this worked on some systems and not on others. 2. Solaris was build-time linking to libawtheadless causing bug 8194870. So build-time linking got removed with that bug. Not sure why that bug is private :( Thanks, Severin

On 10/04/2018 09:34, Erik Joelsson wrote: Looks good. Thanks!

/Erik

On 2018-04-10 04:25, Severin Gehwolf wrote: Hi Erik, On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote: Hello Severin,

I'm ok with this solution for now. Thanks for the review! Could you please reduce the indentation on line 652. In the build system we like 4 spaces for continuation indent [1] Done. New webrev at: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.0 2 Could someone from awt-dev have a look at this too? Thanks! Cheers, Severin /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.h tml On 2018-04-09 06:39, Severin Gehwolf wrote: Hi,

Could somebody please review this build fix for libfontmanager.so. The issue for us is that with some LDFLAGS the build breaks as described in bug JDK-8196218. However, we cannot link to a providing library at build-time since we don't know which one it should be: libawtheadless or libawtxawt. That has to happen at runtime. The proposed fix filters out relevant linker flags when libfontmanager is being built. More details are in the bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webr ev.01/ Testing: I've run this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. --------------------- Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0 UNABLETORUN: 0 EXECUTEDWITHFAILURE: 0 KILLED: 0 PASSED: 82 FAILED: 1 Test 1 Failed tier1-debug-jdkopentesthotspotjtregtier1compiler2- windows-x64- debug-31 SetupFailedException in setup...profile run-test- prebuilt' , return value: 10 -------------------- Not sure what this test failure means. Could somebody at Oracle shed some light on this? Thanks, Severin

More information about the build-dev mailing list