[8u] RFR: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris (original) (raw)

Tim Bell tim.bell at oracle.com
Fri Apr 13 19:08:31 UTC 2018

Kevin - looks good in general with a few remarks (see below):

I'd like to request review of this backport from 9 to 8u:

8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris JBS: https://bugs.openjdk.java.net/browse/JDK-8038340 9 changesets: base repo: http://hg.openjdk.java.net/jdk9/dev/rev/9786ef8ca58c JDK: repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/fdeb6a8b0f3a (clean import to jdk8u-dev) JDK repo change imports cleanly. base repo changes require some manual fixups in: common/autoconf/basics.m4 addition of ACDEFUNONCE([BASICSETUPDEVKIT], fails, done manually common/autoconf/toolchain.m4 minor change didn't import make/common/NativeCompilation.gmk minor change didn't import ...plus run autogen to recreate generated files.

9 review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2014-April/004361.html (thread starts in March, not that it's long, but I don't see a link there to the previous emails in the thread: http://mail.openjdk.java.net/pipermail/2d-dev/2014-March/004333.html ) 8u webrev:http://cr.openjdk.java.net/~kevinw/8038340/webrev.00/ Many thanks! Kevin

common/autoconf/configure.ac

This change looks straightforward, but I don't see the file at all in the JDK 9 webrev...

make/common/autoconf/configure.acdevkit/Makefile

lines 91,92 ... Do you want ccache? It is commented out in the JDK 9 changes (http://cr.openjdk.java.net/~erikj/8038340/webrev.root.02/make/devkit/Makefile.frames.html)

/Tim

More information about the build-dev mailing list