RFR(XS): 8201584: Fix configure on SLES 11 after 8201483 (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Apr 16 13:32:06 UTC 2018

Thanks Magnus and Volker!

Best regards, Goetz.

-----Original Message----- From: Magnus Ihse Bursie [mailto:magnus.ihse.bursie at oracle.com] Sent: Montag, 16. April 2018 14:56 To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; build-dev (build- dev at openjdk.java.net) <build-dev at openjdk.java.net> Subject: Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

On 2018-04-16 14:15, Lindenmaier, Goetz wrote: > Hi Magnus, > > yes, that works too: > http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/02/ > Can I push this right away if I get a second review? You don't need a second review for build changes, it's a hotspot team rule. You can push it right away now. /Magnus > > Best regards, > Goetz > >> -----Original Message----- >> From: Magnus Ihse Bursie [mailto:magnus.ihse.bursie at oracle.com] >> Sent: Montag, 16. April 2018 14:00 >> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; build-dev (build- >> dev at openjdk.java.net) <build-dev at openjdk.java.net> >> Subject: Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483 >> >> On 2018-04-16 11:16, Lindenmaier, Goetz wrote: >>> Hi, >>> >>> could I please get reviewes for this tiny fix? >>> Grep does not grok the syntax of the replacement of space to newline. >>> It causes configure failures on SLES 11. >>> >>> http://cr.openjdk.java.net/~goetz/wr18/8201584- fixSLES11configure/01/ >> Aha, that was the reason for those odd NEEDLE and STACK constructs. :-) >> >> Goetz, please try this patch instead, which uses the new >> BASICGETNONMATCHINGVALUES function. Hopefully, it works >> correctly on >> SLES 11 as well. >> >> diff --git a/make/autoconf/hotspot.m4 b/make/autoconf/hotspot.m4 >> --- a/make/autoconf/hotspot.m4 >> +++ b/make/autoconf/hotspot.m4 >> @@ -443,7 +443,7 @@ >>      ACMSGRESULT(["$JVMFEATURESFORVARIANT"]) >> >>      # Validate features (for configure script errors, not user errors) >> -    INVALIDFEATURES=$GREP -Fvx "${VALIDJVMFEATURES// /$'\n'}"_ _<<<_ _>> "${JVMFEATURESFORVARIANT// /$'\n'}" >> +    BASICGETNONMATCHINGVALUES(INVALIDFEATURES, >> JVMFEATURESFORVARIANT,JVMFEATURESFORVARIANT, JVMFEATURESFORVARIANT,VALIDJVMFEATURES) >>      if test "x$INVALIDFEATURES" != x; then >>        ACMSGERROR([Internal configure script error. Invalid JVM >> feature(s): $INVALIDFEATURES]) >>      fi >> >> /Magnus

More information about the build-dev mailing list