RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent (original) (raw)

Baesken, Matthias matthias.baesken at sap.com
Tue Apr 24 16:09:29 UTC 2018

Hi Jini, the removal of the mentioned headers leads to build errors so we better keep it . Error is when the headers are removed :

/nb/linuxs390x/nightly/jdk/src/hotspot/share/runtime/vmStructs.cpp💯31: fatal error: vmStructs_s390.hpp: No such file or directory #include CPU_HEADER(vmStructs)

I uploaded a webrev for review :

http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/

bug :

https://bugs.openjdk.java.net/browse/JDK-8202200

Best regards, Matthias

-----Original Message----- From: Jini George [mailto:jini.george at oracle.com] Sent: Dienstag, 24. April 2018 08:58 To: Baesken, Matthias <matthias.baesken at sap.com>; 'build- dev at openjdk.java.net' <build-dev at openjdk.java.net> Cc: serviceability-dev at openjdk.java.net; Schmidt, Lutz <lutz.schmidt at sap.com> Subject: Re: INCLUDESA/serviceability agent - support on s390x

Hi Matthias, Your change looks good to me. It might make sense to also remove the following lines from: src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h 78 #if defined(s390x) 79 #include <asm/ptrace.h> 80 #endif I am not sure if the following files are required either: src/hotspot/cpu/s390/vmStructss390.hpp src/hotspot/oscpu/linuxs390/vmStructslinuxs390.hpp Thanks, Jini (Not a Reviewer).

On 4/23/2018 5:31 PM, Baesken, Matthias wrote: > Hello,   as far as I know  the serviceability agent   is not  supported > on  linux s390x . > > However  (unlike  on aix where it is not supported as well) , >  INCLUDESA=false    is not set  in the central configure  m4 files . > > Should we set it  ( suggested diff below)  ? > > Best regards, Matthias > > hg diff > > diff -r fcd5df7aa235 make/autoconf/jdk-options.m4 > > --- a/make/autoconf/jdk-options.m4      Wed Apr 18 11:19:32 2018 +0200 > > +++ b/make/autoconf/jdk-options.m4      Mon Apr 23 13:46:17 2018 +0200 > > @@ -238,6 +238,9 @@ > >    if test "x$OPENJDKTARGETOS" = xaix ; then > >      INCLUDESA=false > >    fi > > +  if test "x$OPENJDKTARGETCPU" = xs390x ; then > > +    INCLUDESA=false > > +  fi > >    ACSUBST(INCLUDESA) > > # Compress jars > > Best regards, Matthias >

More information about the build-dev mailing list