RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1 (original) (raw)
Langer, Christoph christoph.langer at sap.com
Thu Apr 26 14:38:04 UTC 2018
- Previous message (by thread): RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
- Next message (by thread): RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Matthias,
to me the change in principal looks good.
I'm wondering if it is possible to do a comparison like xlc < 13 (e.g. extract major number before the first dot, then compare numerically) - but maybe it is too complicated and the current single version compare suits our needs ?
Best regards Christoph
From: Baesken, Matthias Sent: Donnerstag, 26. April 2018 16:14 To: 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; ppc-aix-port-dev at openjdk.java.net; core-libs-dev at openjdk.java.net Cc: Langer, Christoph <christoph.langer at sap.com>; Simonis, Volker <volker.simonis at sap.com> Subject: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
Hello , could you please review this small adjustment to the symbol visibility compilation settings on AIX ? Currently we use XLC 12.1 to compile JDK on AIX .
However XLC 12.1 does not support the "-qvisibility=hidden" setting currently set on AIX. It was introduced with XLC 13.1 . Christoph found some info about it here :
https://www.ibm.com/developerworks/aix/library/au-aix-symbol-visibility-part2/index.html
Setting it only generates hundreds of warnings in the build log , warnings look like this : XlC12.1
bash-4.4$ xlC -qversion IBM XL C/C++ for AIX, V12.1 (5765-J02, 5725-C72) Version: 12.01.0000.0019
bash-4.4$ xlC -qvisibility=hidden sizeof.c -o sizeof_aixxlc 1506-173 (W) Option visibility=hidden is not valid. Enter xlC for list of valid options.
Compare to XLC13.1
bash-3.00$ xlC -qversion IBM XL C/C++ for AIX, V13.1 (5725-C72, 5765-J07) Version: 13.01.0000.0008 bash-3.00$ xlC -qvisibility=default sizeof.c -o sizeof_aixxlc bash-3.00$ xlC -qvisibility=hidden sizeof.c -o sizeof_aixxlc
So it is better to avoid setting these flags when using xlc12.1 . Please review :
Bug :
https://bugs.openjdk.java.net/browse/JDK-8202322
Change :
http://cr.openjdk.java.net/~mbaesken/webrevs/8202322/
Best regards, Matthias
- Previous message (by thread): RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
- Next message (by thread): RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]