RFR: JDK-8214718 Update missing copyright year in build system (original) (raw)

Tim Bell tim.bell at oracle.com
Mon Dec 3 17:37:33 UTC 2018


Magnus:

Looks good to me as well.

Tim

On 12/03/18 09:35, Erik Joelsson wrote:

Looks good.

/Erik On 2018-12-03 08:30, Magnus Ihse Bursie wrote: Not all changes in 2018 in the build system were accompanied by updates of the copyright year. Add 2018 to files that were actually modified in 2018, but did not get the copyright line updated.

I have found this list by running the updatecopyrightyear script, and then manually verified that the files were indeed modified in 2018, and was not a "dummy" change (such as modifying the copyright header...). Files with "dummy" changes were reverted. I have also manually verified that the script did indeed rewrite the header correctly. (I do not trust scripts... The only good script is a dead scr... nah. But I do not trust them.) As usual, the easiest way to review a change like this is to look at the patch file in webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8214718 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214718-update-missing-copyright-year-2018/webrev.01



More information about the build-dev mailing list