RFR: JDK-8215296 do not disable c99 on Solaris (original) (raw)

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Dec 12 19:08:17 UTC 2018

On 2018-12-12 19:12, Magnus Ihse Bursie wrote:

From the bug report: "Currently we disable C99 in the Solaris build by setting -xc99=%none%. This differs from a lot of other build environments like gcc/Linux or VS2013/2017 on Windows where C99 features work. We should remove this difference on Solaris and remove or replace the setting.

Kim Barrett mentioned : "I merely mentioned the C++14 work as evidence that removing -xc99=%none% didn’t appear harmful." However it will take more time until the C++14 change is in." I am currently running a test build on our CI build system to confirm that this does not break the Solaris build (but I'd be highly surprised if it did). I will not push this until the builds are cleared. Of course it was not that simple... :-( Two AWT libraries (at least) failed to build. I'm currently investigating if there's a simple fix to that.

/Magnus

/Magnus Bug: https://bugs.openjdk.java.net/browse/JDK-8215296 Patch inline: diff --git a/make/autoconf/flags-cflags.m4 b/make/autoconf/flags-cflags.m4 --- a/make/autoconf/flags-cflags.m4 +++ b/make/autoconf/flags-cflags.m4 @@ -559,7 +559,7 @@ TOOLCHAINCFLAGS="-errshort=tags" TOOLCHAINCFLAGSJDK="-mt $TOOLCHAINFLAGS" - TOOLCHAINCFLAGSJDKCONLY="-xc99=%none -xCC -Xa -W0,-noglobal $TOOLCHAINCFLAGS" # C only + TOOLCHAINCFLAGSJDKCONLY="-std=c99 -xCC -W0,-noglobal $TOOLCHAINCFLAGS" # C only TOOLCHAINCFLAGSJDKCXXONLY="-features=no%except -norunpath -xnolib" # CXX only _TOOLCHAINCFLAGSJVM="-template=no%extdef -features=no%splitinit _ -library=stlport4 -mt -features=no%except $TOOLCHAINFLAGS"

More information about the build-dev mailing list