[8u] RFR: 8205104: EXTRA_LDFLAGS not consistently being used (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Fri Jun 15 15:53:48 UTC 2018
- Previous message (by thread): [8u] RFR: 8205104: EXTRA_LDFLAGS not consistently being used
- Next message (by thread): RFR: JDK-8200867 Remove references to "jdk 9" in build system
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good.
/Erik
On 2018-06-15 05:59, Severin Gehwolf wrote:
Hi,
This is a JDK 8u specific problem. It's not applicable to 10/11 since the build system has changed. Make files in JDK 8 live in the hotspot tree, hence, I'm also including hotspot-dev. The issue at hand is that linker flags are not consistently passed down to individual library builds. Specifically libjvm.so, libjsig.so and libsaproc.so. This prevents downstream users from producing hardened builds. We have been using this patch in downstream Fedora for a while now without issues. Please review! Bug: https://bugs.openjdk.java.net/browse/JDK-8205104 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8205104/webrev.01/ Testing: Before: _$ for i in build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjvm.so _ _build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libsaproc.so _ _build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libjsig.so; do _ echo i;readelf−di; readelf -d i;readelf−di | grep NOW done build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjvm.so build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libsaproc.so build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libjsig.so After: _$ for i in build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjvm.so _ _build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libsaproc.so _ _build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libjsig.so; do _ echo i;readelf−di; readelf -d i;readelf−di | grep NOW done build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjvm.so 0x0000000000000018 (BINDNOW) 0x000000006ffffffb (FLAGS1) Flags: NOW build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libsaproc.so 0x0000000000000018 (BINDNOW) 0x000000006ffffffb (FLAGS1) Flags: NOW build/linux-x8664-normal-server-release/images/j2sdk-image/jre/lib/amd64/libjsig.so 0x0000000000000018 (BINDNOW) 0x000000006ffffffb (FLAGS1) Flags: NOW Thanks, Severin
- Previous message (by thread): [8u] RFR: 8205104: EXTRA_LDFLAGS not consistently being used
- Next message (by thread): RFR: JDK-8200867 Remove references to "jdk 9" in build system
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]