RFR: JDK-8200115: System property java.vm.vendor value includes quotation marks (original) (raw)
Abhijit Saha abhijit_saha at hotmail.com
Tue Jun 19 22:04:01 UTC 2018
- Previous message (by thread): RFR: JDK-8200115: System property java.vm.vendor value includes quotation marks
- Next message (by thread): RFR(xxs): 8205407: [windows, vs<2017] C4800 after 8203197
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Jun 19, 2018, at 2:40 PM, Tim Bell <tim.bell at oracle.com> wrote:
Erik:
Since JDK-8189761, the java.vm.vendor string for an OracleJDK build contains quotation marks. This would also be true for any other build of OpenJDK where the user set the --with-vendor-name configure option.
I found the culprit of this to be the combination of the build setting the preprocessor flag as -DVENDOR='"value"' (double quotes inside single quotes) and vmversion.cpp using the XSTR macro to convert the value of VENDOR into a C string. The -DVENDOR argument is also given to libjava, where System.c does not apply a similar conversion, so it requires the double quotes to be supplied on the command line. I found the simplest solution for unifying the behavior between libjvm and libjava to be to remove the XSTR macro call in vmversion.cpp. Bug: https://bugs.openjdk.java.net/browse/JDK-8189761 Er ... the follow-on bug report is: https://bugs.openjdk.java.net/browse/JDK-8200115 Webrev: http://cr.openjdk.java.net/~erikj/8200115/webrev.01/
Looks good to me too.
/Abhijit
Testing: mach5 tier1 Looks good. /Tim
- Previous message (by thread): RFR: JDK-8200115: System property java.vm.vendor value includes quotation marks
- Next message (by thread): RFR(xxs): 8205407: [windows, vs<2017] C4800 after 8203197
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]