RFR: 8186780: clang-4.0 fastdebug assertion failure in os_linux_x86:os::verify_stack_alignment() (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Wed Jun 20 23:54:29 UTC 2018

Looks good to me.

/Erik

On 2018-06-20 16:49, Martin Buchholz wrote:

Thanks Erik.

On Wed, Jun 20, 2018 at 4:19 PM, Erik Joelsson <erik.joelsson at oracle.com <mailto:erik.joelsson at oracle.com>> wrote: Hello, It's very probable that we have made several such mistakes with our flags, since for the most part, we have a 1-1 mapping of compiler and OS. We certainly appreciate correcting this whenever possible. I don't have the expertise to verify your claim here, but I will take your word for it. The change looks ok, but there is already a big block of clang specific stuff close by. Perhaps move this assignment there?

Yes, that does look like a better place:  --- a/make/autoconf/flags-cflags.m4 +++ b/make/autoconf/flags-cflags.m4 @@ -470,14 +470,6 @@ ACDEFUN([FLAGSSETUPCFLAGSHELPER],  # COMMON to gcc and clang  _TOOLCHAINCFLAGSJVM="-pipe -fno-rtti -fno-exceptions _  -fvisibility=hidden -fno-strict-aliasing -fno-omit-frame-pointer" - -    if test "x$TOOLCHAINTYPE" = xclang; then -      # In principle the stack alignment below is cpu- and ABI-dependent and -      # should agree with values of StackAlignmentInBytes in various -      # src/hotspot/cpu//globalDefinitions.hpp files, but this value -      # currently works for all platforms. -      TOOLCHAINCFLAGSJVM="$TOOLCHAINCFLAGSJVM -mno-omit-leaf-frame-pointer -mstack-alignment=16" -    fi  fi  if test "x$TOOLCHAINTYPE" = xgcc; then @@ -499,6 +491,12 @@ ACDEFUN([FLAGSSETUPCFLAGSHELPER],  # (see http://llvm.org/bugs/showbug.cgi?id=7554)  TOOLCHAINCFLAGSJVM="$TOOLCHAINCFLAGSJVM -flimit-debug-info" +    # In principle the stack alignment below is cpu- and ABI-dependent and +    # should agree with values of StackAlignmentInBytes in various +    # src/hotspot/cpu//globalDefinitions.hpp files, but this value +    # currently works for all platforms. +    TOOLCHAINCFLAGSJVM="$TOOLCHAINCFLAGSJVM -mno-omit-leaf-frame-pointer -mstack-alignment=16" +  if test "x$OPENJDKTARGETOS" = xlinux; then  TOOLCHAINCFLAGSJDK="-pipe"  TOOLCHAINCFLAGSJDKCONLY="-fno-strict-aliasing" # technically NOT for CXX

More information about the build-dev mailing list