RFR(XXS) : 8206088 : 8205207 broke builds (original) (raw)
Erik Helin erik.helin at oracle.com
Fri Jun 29 04:56:26 UTC 2018
- Previous message (by thread): RFR(XXS) : 8206088 : 8205207 broke builds
- Next message (by thread): RFR(XXS) : 8206088 : 8205207 broke builds
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 06/29/2018 06:55 AM, Igor Ignatyev wrote:
Hi Erik,
actually, I have a redundant quotation mark at the begging, removed. thanks for spotting this.
Yes, I realized that just as I had sent my email :) Anyways, patch looks good now, Reviewed.
Thanks, Erik
Thanks, -- Igor
On Jun 28, 2018, at 9:50 PM, Erik Helin <erik.helin at oracle.com> wrote:
On 06/29/2018 06:42 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html 1 line changed: 0 ins; 0 del; 1 mod; Hi all, could you please review this one liner fix? webrev: http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html Hmmm, it seems like you are missing an end-of-string quotation mark in + $(info "Skip building of Graal unit tests because 3rd party libraries directory is not specified) Or did I misunderstand the patch? Thanks, Erik
JBS: https://bugs.openjdk.java.net/browse/JDK-8206088 testing: make build-test-hotspot-jtreg-graal w/ empty GRAALUNITLIB Thanks, -- Igor
- Previous message (by thread): RFR(XXS) : 8206088 : 8205207 broke builds
- Next message (by thread): RFR(XXS) : 8206088 : 8205207 broke builds
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]