RFR JDK-8197533 move javax.transaction.xa into its own module (original) (raw)
Paul Sandoz paul.sandoz at oracle.com
Thu Mar 1 01:29:18 UTC 2018
- Previous message (by thread): RFR: JDK-8198862 Stop doing funky compilation stuff for dtrace
- Next message (by thread): RFR JDK-8197533 move javax.transaction.xa into its own module
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Feb 28, 2018, at 1:22 PM, Lance Andersen <lance.andersen at oracle.com> wrote:
On Feb 28, 2018, at 2:20 PM, Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>> wrote: Hi Paul, Thank you for the review. On Feb 28, 2018, at 1:40 PM, Paul Sandoz <paul.sandoz at oracle.com <mailto:paul.sandoz at oracle.com>> wrote:
Compatible module refactoring in action! Looks good, one comment: test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java This is not a valid Java source file can you merge the jtreg meta data into XAExceptionTests instead? As we discussed offline, I will change the above file and Driver.java. I naively assumed this was OK as the change to add Driver.java was made after I had originally added these tests in 2015. http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ <http://cr.openjdk.java.net/~lancea/8197533/webrev.01/> has the updated tests
+1, i second Joe’s request to update package-info.java while we are opportunistically cleaning this area up.
Paul.
- Previous message (by thread): RFR: JDK-8198862 Stop doing funky compilation stuff for dtrace
- Next message (by thread): RFR JDK-8197533 move javax.transaction.xa into its own module
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]