RFR: JDK-8198751 Refactor SetupNativeCompilation to take NAME and TYPE (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Thu Mar 1 23:11:19 UTC 2018
- Previous message (by thread): [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers
- Next message (by thread): RFR: JDK-8198724 Refactor FLAGS handling in configure
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good.
/Erik
On 2018-02-27 03:15, Magnus Ihse Bursie wrote:
Currently, SetupNativeCompilation takes as "main" argument either LIBRARY := name,PROGRAM:=name, PROGRAM := name,PROGRAM:=name or STATICLIBRARY := $name.
This confounds two distinct concepts: the name of the generated binary, and the type of binary to create. Instead, we should have a NAME argument and a TYPE argument. I also took the liberty of updating the code to more modern standards wrt whitespace, and fixed the "Yoda style" if conditions. Bug: https://bugs.openjdk.java.net/browse/JDK-8198751 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8198751-fix-NativeCompilation-NAME-and-TYPE/webrev.01 /Magnus
- Previous message (by thread): [OpenJDK 2D-Dev] RFR: JDK-8198844 Clean up GensrcX11Wrappers
- Next message (by thread): RFR: JDK-8198724 Refactor FLAGS handling in configure
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]