RFR: JDK-8199224 Refactor add_native_source in SetupNativeCompilation (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Wed Mar 7 16:28:13 UTC 2018


Looks good. Nice cleanup!

/Erik

On 2018-03-07 06:02, Magnus Ihse Bursie wrote:

The function addnativesource has been with us since the original version of the build-infra system. It needs to be adapted to modern standards, and to have the flag setting unified so it happens in only one place.

I have verified using BUILDCOMPARE that this does not affect the generated output. Bug: https://bugs.openjdk.java.net/browse/JDK-8199224 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8199224-refactor-addnativesource/webrev.01 /Magnus



More information about the build-dev mailing list