Contribution to make/Docs.gmk (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Thu Mar 8 16:00:44 UTC 2018

Hello,

On 2018-03-08 06:51, Archana Nogriya wrote:

Hi,

In "make/Docs.gmk" We have found 2 issues which required to be fixed in OpenJDK, 1) -JDKMODULES := (sort(sort (sort(DOCSMODULES)) +JDKMODULES := (sort(sort (sort(filter-out (MODULESFILTER),(MODULESFILTER), (MODULESFILTER),(DOCSMODULES))) ==> This is an OpenJDK bug as this should be filtering out the MODULESFILTER modules... hence required contribute to OpenJDK... Yes, this makes sense. The filter should apply here too. 2) -JVMTIHTML := $(HOTSPOTOUTPUTDIR)/variant-$(JVMVARIANTMAIN)/gensrc/jvmtifiles/jvmti.html _-$(eval $(call SetupCopyFiles, COPYJVMTIHTML, _ _FILES := $(JVMTIHTML), _ DEST := $(DOCSOUTPUTDIR)/specs, -)) -JDKSPECSTARGETS += $(COPYJVMTIHTML) +#JVMTIHTML := $(HOTSPOTOUTPUTDIR)/variant-$(JVMVARIANTMAIN)/gensrc/jvmtifiles/jvmti.html +#$(eval $(call SetupCopyFiles, COPYJVMTIHTML, +# FILES := $(JVMTIHTML), +# DEST := $(DOCSOUTPUTDIR)/specs, +#)) +#JDKSPECSTARGETS += $(COPYJVMTIHTML) ==> We need to be able to unset/filterout the $(COPYJVMTIHTML) value in JDKSPECSTARGETS, if we get a "post" CustomIncludeExtension added at the end of Docs.gmk we can then the unset/filterout $(COPYJVMTIHTML) value. Hence OpenJDK contribution required. Adding pre and post hooks to (almost) any .gmk file should not be a problem. It is the preferred solution here.

/Erik

Please would like to hear other views on this fix and if we have better way of dealing this.

Thanks and Regards Archana Nogriya IBM Java Runtime, Open Java Developer IBM Hursley Tel: Internal - 247073, External - +44 (0) 1962 81 7073 Office Mobile: 07500095480 Email: archana.nogriya at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

More information about the build-dev mailing list