RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager (original) (raw)

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Mar 14 11:45:21 UTC 2018

This is the final LDFLAGS cleanup, which required some more work to resolve.

Libfontmanager had previously explicitely disabled -z defs, with the result that linking did not complain about missing libraries. To fix this, I had to provide the proper libraries to link with. For linux and solaris, this was libawt_headless. For macosx, this was libawt_lwawt, but also three system frameworks.

Note that this patch has a merge conflict with JDK-8199606. The end result of both patches are shown in the patch (that is, with -lc removed). I will make sure to resolve the conflicts properly when committing this patch.

I have run COMPARE_BUILDS, with expected results. That is, no changes for Windows, and a deps change for macosx, linux and solaris. I also got a symbol change for linux, since the symbols from libawt_headless changed from e.g. "AWTCharAdvance" to "AWTCharAdvance@@SUNWprivate_1.1". And of course, when you do linking changes, you also end up getting binary/disasm changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-8199608 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8199608-clean-up-LDFLAGS-for-libfontmanager/webrev.01

More information about the build-dev mailing list