RFR: JDK-8199745: JDK-8199668 introduced a build race on macosx (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Fri Mar 16 18:52:01 UTC 2018
- Previous message (by thread): RFR: build pragma error with gcc 4.4.7
- Next message (by thread): RFR: JDK-8199745: JDK-8199668 introduced a build race on macosx
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello,
JDK-8199668 introduced a race in the macosx build. The library libawt_lawt links against libosxapp. Before the change, the declaration of libosxapp happened before libawt_lawt, but in that change the order reversed. This makes the dependency declaration between them no longer functioning.
To fix this I changed the relevant instances of $(BUILD_LIBFOO) to $(call FindLib, module, foo). The problem with using BUILD_LIBFOO is that it is only defined in the same makefile context and after the call to SetupNativeCompilation for it. The FindLib macro can be used anywhere.
While fixing this I found more similar broken dependency declarations and fixed those as well including some cleanup. I did not replace all instances. Maybe we should, but I assume this will get handled differently with the further cleanups in this area.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199745
Webrev: http://cr.openjdk.java.net/~erikj/8199745/webrev.01/
/Erik
- Previous message (by thread): RFR: build pragma error with gcc 4.4.7
- Next message (by thread): RFR: JDK-8199745: JDK-8199668 introduced a build race on macosx
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]