RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows (original) (raw)
Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Mar 22 10:06:41 UTC 2018
- Previous message (by thread): RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows
- Next message (by thread): [11] RFR(XS) 8199896: [Graal] build Graal on all x86 platforms
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2018-03-21 23:05, Erik Joelsson wrote:
On Windows, we have been linking libjvm.so with -base:0x8000000 since forever. This may have been a good idea on earlier versions of windows, but with VS2017 it generates a warning and with ASLR, the address a given binary is loaded at will vary between runs anyway, so there is little point setting this linker option anymore (since Windows Vista). So I propose we just remove it.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198652 Webrev: http://cr.openjdk.java.net/~erikj/8198652/webrev.01/ Looks good to me. Thanks for fixing this!
/Magnus
/Erik
- Previous message (by thread): RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows
- Next message (by thread): [11] RFR(XS) 8199896: [Graal] build Graal on all x86 platforms
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]