RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js (original) (raw)
Erik Joelsson erik.joelsson at oracle.com
Thu Nov 1 16:30:40 UTC 2018
- Previous message (by thread): RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js
- Next message (by thread): minimal gcc version for jdk/jdk and usage of -Wno-int-in-bool-context flag in HS build
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good.
/Erik
On 2018-11-01 03:06, Magnus Ihse Bursie wrote:
In JDK-8210958, a broken version of jib-profiles.js was unfortunately checked in.
The change at http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.02/make/conf/jib-profiles.js.udiff.html, as reviewed, was unfortunately reverted in the process. Without this fix, the *-testmake profiles fails when run. Bug: https://bugs.openjdk.java.net/browse/JDK-8213237 Patch inline: diff --git a/make/conf/jib-profiles.js b/make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js +++ b/make/conf/jib-profiles.js @@ -485,7 +485,7 @@ .forEach(function (name) { var maketestName = name + "-testmake"; profiles[maketestName] = concatObjects(profiles[name], testmakeBase); - profiles[maketestName].defaultmaketargets = [ "test-make", "test-compile-commands" ]; + profiles[maketestName].defaultmaketargets = [ "test-make" ]; }); // Profiles for building the zero jvm variant. These are used for verification. /Magnus (Sorry for the mess :-()
- Previous message (by thread): RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js
- Next message (by thread): minimal gcc version for jdk/jdk and usage of -Wno-int-in-bool-context flag in HS build
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]