[PATCH] JDK-8167368 Leftover: get_source.sh in build documentation (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Tue Nov 13 18:30:30 UTC 2018

Good catch, that should indeed be corrected. I would also remove the "all repositories" part. Something like:

"Run hg pull -u to make sure you have the latest changes."

/Erik

On 2018-11-12 12:45, Sergey wrote:

Hi,

I'm not sure if that's the right mailing list, however, I'll try. Recently, when I was taking a closer look at build documentation: * doc/building.html * doc/building.md I've noticed there getsource.sh being mentioned. I believe that's a leftover of JEP-296 Consolidate JDK Forest into a Single Repository. I've made a trivial patch and want to contribute it. Please find it inlined below. Thanks, Sergei diff --git a/doc/building.html b/doc/building.html --- a/doc/building.html +++ b/doc/building.html @@ -784,7 +784,7 @@

Here are a suggested list of things to try if you are having unexpected

build problems. Each step requires more time than the one before, so try them in order. Most issues will be solved at step 1 or 2.

  1. Make sure your forest is up-to-date

    2.  -

    Run bash getsource.sh to make sure you have the latest

     version of all repositories.

     +

    Run hg pull -u to make sure you have the latest version of

     all repositories.

  2. Clean build results

    3.

    The simplest way to fix incremental rebuild issues is to run make

     clean. This will remove all build results, but not the configuration or any build system support artifacts. In most cases, this will solve build errors resulting from incremental build mismatches.

  3. Completely clean the build directory.

    4.  diff --git a/doc/building.md b/doc/building.md --- a/doc/building.md +++ b/doc/building.md @@ -1310,7 +1310,7 @@ 1. Make sure your forest is up-to-date - Run bash getsource.sh to make sure you have the latest version of all + Run hg pull -u to make sure you have the latest version of all repositories. 2. Clean build results

    More information about the build-dev mailing list